You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
265 lines
10 KiB
265 lines
10 KiB
"""Tests for analysis/right_wing/common.py shared module.
|
|
|
|
TDD approach: these tests verify the extracted shared helpers work correctly.
|
|
"""
|
|
|
|
import math
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import numpy as np
|
|
import pytest
|
|
|
|
|
|
class TestConstants:
|
|
"""Verify all exported constants are present and correctly typed."""
|
|
|
|
def test_canonical_centrist_is_frozenset(self):
|
|
from analysis.right_wing.common import CANONICAL_CENTRIST
|
|
assert isinstance(CANONICAL_CENTRIST, frozenset)
|
|
assert "VVD" in CANONICAL_CENTRIST
|
|
assert "D66" in CANONICAL_CENTRIST
|
|
assert "CDA" in CANONICAL_CENTRIST
|
|
assert "NSC" in CANONICAL_CENTRIST
|
|
assert "BBB" in CANONICAL_CENTRIST
|
|
assert "CU" in CANONICAL_CENTRIST
|
|
|
|
def test_canonical_centrist_strict_subset(self):
|
|
from analysis.right_wing.common import CANONICAL_CENTRIST, CANONICAL_CENTRIST_STRICT
|
|
assert CANONICAL_CENTRIST_STRICT.issubset(CANONICAL_CENTRIST)
|
|
assert "VVD" not in CANONICAL_CENTRIST_STRICT
|
|
assert "BBB" not in CANONICAL_CENTRIST_STRICT
|
|
|
|
def test_canonical_left_right_disjoint(self):
|
|
from analysis.right_wing.common import CANONICAL_LEFT, CANONICAL_RIGHT
|
|
assert len(CANONICAL_LEFT & CANONICAL_RIGHT) == 0
|
|
|
|
def test_coalition_dicts(self):
|
|
from analysis.right_wing.common import RUTTE_IV_COALITION, SCHOOF_COALITION
|
|
assert isinstance(RUTTE_IV_COALITION, set)
|
|
assert isinstance(SCHOOF_COALITION, set)
|
|
assert "PVV" in SCHOOF_COALITION
|
|
assert "PVV" not in RUTTE_IV_COALITION
|
|
|
|
def test_time_constants(self):
|
|
from analysis.right_wing.common import YEAR_MIN, YEAR_MAX, BREAK_YEAR
|
|
assert YEAR_MIN < BREAK_YEAR < YEAR_MAX
|
|
assert BREAK_YEAR == 2024
|
|
|
|
def test_paths_exist(self):
|
|
from analysis.right_wing.common import ROOT, DB_PATH, REPORTS_DIR
|
|
assert ROOT.exists()
|
|
assert isinstance(DB_PATH, str)
|
|
assert "motions.db" in DB_PATH
|
|
assert isinstance(REPORTS_DIR, Path)
|
|
|
|
|
|
class TestCohensD:
|
|
"""Test Cohen's d effect size calculation."""
|
|
|
|
def test_identical_groups_returns_zero(self):
|
|
from analysis.right_wing.common import cohens_d
|
|
d = cohens_d([1, 2, 3], [1, 2, 3])
|
|
assert d == 0.0
|
|
|
|
def test_first_group_higher(self):
|
|
from analysis.right_wing.common import cohens_d
|
|
# cohens_d(x, y) = (mean_y - mean_x) / pooled_std (based on implementation)
|
|
d = cohens_d([4, 5, 6], [1, 2, 3])
|
|
assert d < 0 # mean_y < mean_x → negative
|
|
|
|
def test_second_group_higher(self):
|
|
from analysis.right_wing.common import cohens_d
|
|
d = cohens_d([1, 2, 3], [4, 5, 6])
|
|
assert d > 0 # mean_y > mean_x → positive
|
|
|
|
def test_known_value(self):
|
|
from analysis.right_wing.common import cohens_d
|
|
# [1,2,3,4,5] vs [3,4,5,6,7]: mean diff = -2, pooled std ≈ 1.58
|
|
d = cohens_d([1, 2, 3, 4, 5], [3, 4, 5, 6, 7])
|
|
assert d > 0 # Second group has higher mean
|
|
assert abs(d) > 1.0 # Should be a large effect
|
|
|
|
|
|
class TestQuarterSortKey:
|
|
"""Test quarter string sorting."""
|
|
|
|
def test_basic_sort(self):
|
|
from analysis.right_wing.common import quarter_sort_key
|
|
assert quarter_sort_key("2024-Q1") < quarter_sort_key("2024-Q2")
|
|
assert quarter_sort_key("2023-Q4") < quarter_sort_key("2024-Q1")
|
|
|
|
def test_sort_order(self):
|
|
from analysis.right_wing.common import quarter_sort_key
|
|
quarters = ["2024-Q3", "2024-Q1", "2023-Q4", "2024-Q2"]
|
|
sorted_q = sorted(quarters, key=quarter_sort_key)
|
|
assert sorted_q == ["2023-Q4", "2024-Q1", "2024-Q2", "2024-Q3"]
|
|
|
|
def test_invalid_format_raises(self):
|
|
from analysis.right_wing.common import quarter_sort_key
|
|
with pytest.raises((ValueError, IndexError)):
|
|
quarter_sort_key("invalid")
|
|
|
|
|
|
class TestFindInflectionPoint:
|
|
"""Test inflection point detection using 3-quarter rolling average."""
|
|
|
|
def test_simple_inflection(self):
|
|
from analysis.right_wing.common import find_inflection_point
|
|
quarters = ["2023-Q4", "2024-Q1", "2024-Q2", "2024-Q3", "2024-Q4"]
|
|
values = [0.2, 0.5, 0.6, 0.7, 0.8]
|
|
result = find_inflection_point(quarters, values, threshold=0.4)
|
|
# Rolling avg at index 1: (0.2 + 0.5 + 0.6)/3 = 0.433 > 0.4
|
|
assert result == "2024-Q1"
|
|
|
|
def test_no_inflection(self):
|
|
from analysis.right_wing.common import find_inflection_point
|
|
quarters = ["2023-Q4", "2024-Q1", "2024-Q2", "2024-Q3"]
|
|
values = [0.1, 0.15, 0.2, 0.25]
|
|
result = find_inflection_point(quarters, values, threshold=0.4)
|
|
assert result is None
|
|
|
|
def test_inflection_at_end(self):
|
|
from analysis.right_wing.common import find_inflection_point
|
|
quarters = ["2023-Q4", "2024-Q1", "2024-Q2", "2024-Q3", "2024-Q4"]
|
|
values = [0.1, 0.15, 0.2, 0.5, 0.6]
|
|
result = find_inflection_point(quarters, values, threshold=0.4)
|
|
# Rolling avg at index 3: (0.2 + 0.5 + 0.6)/3 = 0.433 > 0.4
|
|
assert result == "2024-Q3"
|
|
|
|
def test_too_short_returns_none(self):
|
|
from analysis.right_wing.common import find_inflection_point
|
|
result = find_inflection_point(["2024-Q1", "2024-Q2"], [0.5, 0.6], 0.4)
|
|
assert result is None
|
|
|
|
|
|
class TestMotionPassed:
|
|
"""Test motion passage detection via result field."""
|
|
|
|
def test_aangenomen_passes(self):
|
|
from analysis.right_wing.common import motion_passed
|
|
votes = {"result": "aangenomen", "voor": 100, "tegen": 50}
|
|
assert motion_passed(votes) is True
|
|
|
|
def test_verworpen_fails(self):
|
|
from analysis.right_wing.common import motion_passed
|
|
votes = {"result": "verworpen", "voor": 30, "tegen": 70}
|
|
assert motion_passed(votes) is False
|
|
|
|
def test_none_fails(self):
|
|
from analysis.right_wing.common import motion_passed
|
|
assert motion_passed(None) is False
|
|
|
|
def test_empty_dict_fails(self):
|
|
from analysis.right_wing.common import motion_passed
|
|
assert motion_passed({}) is False
|
|
|
|
def test_json_string_parses(self):
|
|
from analysis.right_wing.common import motion_passed
|
|
votes = '{"result": "aangenomen", "voor": 100}'
|
|
assert motion_passed(votes) is True
|
|
|
|
def test_invalid_json_fails(self):
|
|
from analysis.right_wing.common import motion_passed
|
|
assert motion_passed("not json") is False
|
|
|
|
|
|
class TestBuildPartyNameMap:
|
|
"""Test MP name to party mapping."""
|
|
|
|
def test_returns_dict(self):
|
|
from analysis.right_wing.common import build_party_name_map, _conn, DB_PATH
|
|
with _conn(DB_PATH) as con:
|
|
result = build_party_name_map(con)
|
|
assert isinstance(result, dict)
|
|
assert len(result) > 100 # Should have many MPs
|
|
|
|
def test_known_mp_maps_to_party(self):
|
|
from analysis.right_wing.common import build_party_name_map, _conn, DB_PATH
|
|
with _conn(DB_PATH) as con:
|
|
result = build_party_name_map(con)
|
|
# Wilders should map to PVV
|
|
assert "Wilders" in result
|
|
assert result["Wilders"] == "PVV"
|
|
|
|
def test_groenlinks_pvda_normalized(self):
|
|
from analysis.right_wing.common import build_party_name_map, _conn, DB_PATH
|
|
with _conn(DB_PATH) as con:
|
|
result = build_party_name_map(con)
|
|
# Klaver should map to GroenLinks-PvdA
|
|
assert "Klaver" in result
|
|
assert result["Klaver"] == "GroenLinks-PvdA"
|
|
|
|
|
|
class TestParseLeadSubmitter:
|
|
"""Test motion title parsing for lead MP name."""
|
|
|
|
def test_standard_motie_format(self):
|
|
from analysis.right_wing.common import parse_lead_submitter
|
|
title = "Motie van het lid Wilders over migratie"
|
|
name, party = parse_lead_submitter(title, {"Wilders": "PVV"})
|
|
assert name == "Wilders"
|
|
assert party == "PVV"
|
|
|
|
def test_gewijzigde_motie_format(self):
|
|
from analysis.right_wing.common import parse_lead_submitter
|
|
title = "Gewijzigde Motie van het lid Klaver c.s. over klimaat"
|
|
name, party = parse_lead_submitter(title, {"Klaver": "GL"})
|
|
assert name == "Klaver"
|
|
|
|
def test_amendement_format(self):
|
|
from analysis.right_wing.common import parse_lead_submitter
|
|
title = "Amendement van het lid Omtzigt over begroting"
|
|
name, party = parse_lead_submitter(title, {"Omtzigt": "NSC"})
|
|
assert name == "Omtzigt"
|
|
|
|
def test_non_motie_returns_none(self):
|
|
from analysis.right_wing.common import parse_lead_submitter
|
|
title = "Verslag van een schriftelijk overleg"
|
|
name, party = parse_lead_submitter(title, {})
|
|
assert name is None
|
|
assert party is None
|
|
|
|
def test_empty_title_returns_none(self):
|
|
from analysis.right_wing.common import parse_lead_submitter
|
|
name, party = parse_lead_submitter("", {})
|
|
assert name is None
|
|
|
|
|
|
class TestConnectionHelper:
|
|
"""Test _conn context manager."""
|
|
|
|
def test_conn_returns_context_manager(self):
|
|
from analysis.right_wing.common import _conn, DB_PATH
|
|
# Should not raise when using the default DB_PATH
|
|
with _conn(DB_PATH) as con:
|
|
assert con is not None
|
|
# Verify it's a valid connection
|
|
result = con.execute("SELECT 1").fetchone()
|
|
assert result[0] == 1
|
|
|
|
|
|
class TestIntegration:
|
|
"""Integration tests verifying common.py works with real data."""
|
|
|
|
def test_db_path_points_to_existing_file(self):
|
|
from analysis.right_wing.common import DB_PATH
|
|
from pathlib import Path
|
|
assert Path(DB_PATH).exists(), f"Database not found at {DB_PATH}"
|
|
|
|
def test_reports_dir_exists(self):
|
|
from analysis.right_wing.common import REPORTS_DIR
|
|
assert REPORTS_DIR.exists(), f"Reports dir not found: {REPORTS_DIR}"
|
|
|
|
def test_centrist_parties_in_database(self):
|
|
"""Verify CANONICAL_CENTRIST parties actually exist in mp_votes."""
|
|
from analysis.right_wing.common import CANONICAL_CENTRIST, _conn, DB_PATH
|
|
with _conn(DB_PATH) as con:
|
|
db_parties = {r[0] for r in con.execute(
|
|
"SELECT DISTINCT party FROM mp_votes WHERE party IS NOT NULL"
|
|
).fetchall()}
|
|
|
|
# Check that at least some centrist parties are in the database
|
|
found = CANONICAL_CENTRIST & db_parties
|
|
assert len(found) >= 4, f"Only {found} centrist parties found in mp_votes"
|
|
|
|
|