import logging
from typing import Optional

import requests

from database import MotionDatabase

logger = logging.getLogger(__name__)


def normalize_mp_name(
    achternaam: str, initialen: Optional[str], tussenvoegsel: Optional[str]
) -> str:
    """Reconstruct ActorNaam format used in voting_results keys.

    Format: "{Tussenvoegsel} {Achternaam}, {Initialen}" with sensible stripping when
    tussenvoegsel is missing.
    """
    parts = []
    if tussenvoegsel:
        parts.append(tussenvoegsel)
    parts.append(achternaam)
    name = " ".join(parts).strip()

    # Ensure the displayed name starts with an uppercase letter so
    # ORDER BY mp_name behaves predictably across databases that may
    # sort uppercase before lowercase. Only change the first character
    # to upper-case to avoid lowercasing other letters (e.g. hyphenated
    # or already capitalized parts).
    if name and name[0].islower():
        name = name[0].upper() + name[1:]
    if initialen:
        name = f"{name}, {initialen}"
    return name


def fetch_mp_metadata(
    db_path: str, odata_url: str = "https://odata.example/FractieZetelPersoon"
) -> int:
    """Fetch MP party membership and tenure from OData and upsert into DB.

    Returns the number of records processed (inserted or updated).
    """
    session = requests.Session()
    try:
        resp = session.get(odata_url)
        resp.raise_for_status()
        data = resp.json()
    except Exception as e:
        logger.error("Failed to fetch MP metadata: %s", e)
        raise

    values = data.get("value") if isinstance(data, dict) else None
    if values is None:
        logger.error("Unexpected OData payload; missing 'value' list")
        return 0

    db = MotionDatabase(db_path)
    processed = 0

    for item in values:
        try:
            persoon = item.get("Persoon") or {}
            fractiezetel = item.get("FractieZetel") or {}
            fractie = fractiezetel.get("Fractie") or {}

            achternaam = persoon.get("Achternaam")
            initialen = persoon.get("Initialen")
            tussenvoegsel = persoon.get("Tussenvoegsel")
            persoon_id = persoon.get("Id")

            party = fractie.get("NaamNL")
            van = item.get("Van")
            tot_en_met = item.get("TotEnMet")

            if not achternaam:
                logger.debug("Skipping record without achternaam: %s", item)
                continue

            mp_name = normalize_mp_name(achternaam, initialen, tussenvoegsel)

            db.upsert_mp_metadata(
                mp_name=mp_name,
                party=party,
                van=van,
                tot_en_met=tot_en_met,
                persoon_id=persoon_id,
            )
            processed += 1
        except Exception:
            logger.exception("Error processing OData item: %s", item)

    logger.info("Processed %d MP metadata records", processed)
    return processed