From 80c68c01124e52d7e0e28cde3b0e6dc1ec8b5255 Mon Sep 17 00:00:00 2001 From: Sven Geboers Date: Mon, 25 May 2026 00:01:31 +0200 Subject: [PATCH] fix(right-wing): match store_scores column names and value order to DB schema --- analysis/right_wing/extremity_rescore_2d.py | 12 ++++++------ tests/right_wing/test_extremity_rescore_2d.py | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/analysis/right_wing/extremity_rescore_2d.py b/analysis/right_wing/extremity_rescore_2d.py index 750ecab..1e0c5df 100644 --- a/analysis/right_wing/extremity_rescore_2d.py +++ b/analysis/right_wing/extremity_rescore_2d.py @@ -228,10 +228,10 @@ def store_scores(db_path: str, results: list[dict[str, Any]]) -> int: """ CREATE TABLE IF NOT EXISTS extremity_scores_2d ( motion_id INTEGER PRIMARY KEY, - stylistic_score INTEGER NOT NULL, - material_score INTEGER NOT NULL, - stylistic_rationale TEXT, - material_rationale TEXT + stijl_extremiteit INTEGER NOT NULL, + stijl_toelichting TEXT, + materiele_impact INTEGER NOT NULL, + materiele_toelichting TEXT ) """ ) @@ -241,14 +241,14 @@ def store_scores(db_path: str, results: list[dict[str, Any]]) -> int: con.execute( """ INSERT OR REPLACE INTO extremity_scores_2d - (motion_id, stylistic_score, material_score, stylistic_rationale, material_rationale) + (motion_id, stijl_extremiteit, stijl_toelichting, materiele_impact, materiele_toelichting) VALUES (?, ?, ?, ?, ?) """, ( r["motion_id"], r["stijl_extremiteit"], - r["materiele_impact"], r.get("stijl_toelichting"), + r["materiele_impact"], r.get("materiele_toelichting"), ), ) diff --git a/tests/right_wing/test_extremity_rescore_2d.py b/tests/right_wing/test_extremity_rescore_2d.py index 0911eec..1e554c5 100644 --- a/tests/right_wing/test_extremity_rescore_2d.py +++ b/tests/right_wing/test_extremity_rescore_2d.py @@ -177,7 +177,7 @@ class TestStoreScores: con = duckdb.connect(tmp_duckdb_path) try: rows = con.execute( - "SELECT motion_id, stylistic_score, material_score " + "SELECT motion_id, stijl_extremiteit, materiele_impact " "FROM extremity_scores_2d ORDER BY motion_id" ).fetchall() assert len(rows) == 2 @@ -206,7 +206,7 @@ class TestStoreScores: con = duckdb.connect(tmp_duckdb_path) try: rows = con.execute( - "SELECT stylistic_score, material_score FROM extremity_scores_2d WHERE motion_id = 1" + "SELECT stijl_extremiteit, materiele_impact FROM extremity_scores_2d WHERE motion_id = 1" ).fetchall() assert rows[0] == (5, 5) finally: